Fix menu not closing when clicking tabs#818
Merged
Merged
Conversation
5 tasks
krassowski
reviewed
May 18, 2026
krassowski
approved these changes
May 20, 2026
krassowski
left a comment
krassowski
left a comment
Member
There was a problem hiding this comment.
Looks good to me.
Another very long shot but @afshin any chance you recall why this was not changed in lumino v2 PR? More likely forgotten about or was there a reason not to do it?
krassowski
changed the title
Member
|
@krassowski @Darshan808 I can't remember a reason. I think this change is good. It's possible I was being cautious for some now-forgotten reason. It's possible it was just an omission, but it's pretty big, so I think it was more likely caution than anything else. Thanks for the updates! |
jtpio
pushed a commit
to jupyterlab/jupyterlab
that referenced
this pull request
May 26, 2026
## References - brings the enhancement requested in #10514 - follow-up to #18703 ## Code changes None ## User-facing changes Pulls fixes for two bugs: - jupyterlab/lumino#819 - jupyterlab/lumino#818 And makes closing multiple tabs easier: - jupyterlab/lumino#793 https://github.com/user-attachments/assets/18fb096e-b48c-4a27-a5b4-c459cfc147de ## Backwards-incompatible changes None ## AI usage None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes jupyterlab/jupyterlab#18851
Description
Switch document listener from
mousedowntopointerdownso outside clicks are detected even when tab clicks callpreventDefault(), which was blocking the old event flow.Before:
Screen.Recording.2026-05-18.at.14.37.07.mov
After:
Screen.Recording.2026-05-18.at.14.38.05.mov